feat: add `fixer` function `eslint/rules/repl-namespace-order` #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Planeshifter merged 8 commits into stdlib-js:develop from headlessNode:lint-repl-order

Jan 11, 2025

Member

headlessNode commented Dec 6, 2024

Description

What is the purpose of this pull request?

This pull request:

add fixer function to eslint/rules/repl-namespace-order to allow auto-fixing.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers


          feat: add fixer function

8630e60

headlessNode added Feature Accepted Tools and removed Accepted labels

headlessNode commented

View reviewed changes

lib/node_modules/@stdlib/_tools/eslint/rules/repl-namespace-order/lib/main.js Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/_tools/eslint/rules/repl-namespace-order/lib/main.js Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/_tools/eslint/rules/repl-namespace-order/lib/main.js Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/_tools/eslint/rules/repl-namespace-order/lib/main.js Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/_tools/eslint/rules/repl-namespace-order/lib/main.js Outdated Show resolved Hide resolved


          refactor: apply review suggestions

dcf3c37

headlessNode commented

View reviewed changes

lib/node_modules/@stdlib/_tools/eslint/rules/repl-namespace-order/lib/main.js Outdated Show resolved Hide resolved

headlessNode commented

View reviewed changes

lib/node_modules/@stdlib/_tools/eslint/rules/repl-namespace-order/lib/main.js Outdated Show resolved Hide resolved


          fix: update meta type property

86e63b1

Signed-off-by: Muhammad Haris <[email protected]>

headlessNode marked this pull request as ready for review

December 10, 2024 18:28

stdlib-bot added the Needs Review label

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/_tools/eslint/rules/repl-namespace-order/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/_tools/eslint/rules/repl-namespace-order/lib/main.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/_tools/eslint/rules/repl-namespace-order/lib/main.js Outdated Show resolved Hide resolved

kgryte requested a review from Planeshifter

December 13, 2024 03:10

headlessNode and others added 3 commits

December 15, 2024 19:50


          refactor: apply review suggestion

4f0a300

Co-authored-by: Athan <[email protected]>
Signed-off-by: Muhammad Haris <[email protected]>


          refactor: apply review suggestion

Co-authored-by: Athan <[email protected]>
Signed-off-by: Muhammad Haris <[email protected]>


          refactor: apply review suggestion

608b63c

headlessNode requested a review from kgryte

December 28, 2024 08:55


          chore: remove lint directive in example and update wording

04f0bc0

Planeshifter approved these changes

View reviewed changes

Member

Planeshifter left a comment

Thanks, @headlessNode! Looks good to me.

Planeshifter added the Ready To Merge label

stdlib-bot removed the Needs Review label

Contributor

stdlib-bot commented Jan 11, 2025

PR Commit Message

feat: add `fixer` function `eslint/rules/repl-namespace-order`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3350

Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Muhammad Haris <[email protected]>

Please review the above commit message and make any necessary adjustments.


          chore: fix whitespace in README.md file

bf1208a

Planeshifter merged commit caa46c4 into stdlib-js:develop

8 checks passed

headlessNode deleted the lint-repl-order branch

January 11, 2025 21:47

Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request


          feat: add fixer function eslint/rules/repl-namespace-order

035bac6

PR-URL: stdlib-js#3350

Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Muhammad Haris <[email protected]>

ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request


          feat: add fixer function eslint/rules/repl-namespace-order

487c5b4

PR-URL: stdlib-js#3350

Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Muhammad Haris <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Ready To Merge Tools